Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inductor] [Doc] Add tutorial for Inductor Cpp Wrapper as a prototype feature for PyTorch 2.1 #2510

Merged
merged 45 commits into from
Oct 2, 2023
Merged

[Inductor] [Doc] Add tutorial for Inductor Cpp Wrapper as a prototype feature for PyTorch 2.1 #2510

merged 45 commits into from
Oct 2, 2023

Conversation

chunyuan-w
Copy link
Contributor

@chunyuan-w chunyuan-w commented Jul 27, 2023 •
edited
Loading

Description

Inductor Cpp Wrapper has been proposed as a prototype feature for PyTorch 2.1. This PR adds the tutorial for this feature.

Rendered version: link.

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 27, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2510

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fe47acd with merge base 550c401 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@netlify
Copy link

netlify bot commented Jul 27, 2023 •
edited
Loading

❌ Deploy Preview for pytorch-tutorials-preview failed.

Name Link
🔨 Latest commit d6e99b5
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/64c9cef728258800089301f1

@chunyuan-w chunyuan-w changed the title [Inductor] [Doc] Add Inductor Cpp Wrapper tutorial as a prototype feature for PyTorch 2.1 [Inductor] [Doc] Add tutorial for Inductor Cpp Wrapper as a prototype feature for PyTorch 2.1 Jul 27, 2023
@chunyuan-w chunyuan-w marked this pull request as ready for review July 27, 2023 06:34
@chunyuan-w
Copy link
Contributor Author

cc @jgong5

jgong5
jgong5 reviewed Jul 27, 2023
View reviewed changes
prototype_source/inductor_cpp_wrapper_tutorial.rst Outdated

Example code
------------
Below is an example of generated code with the default python wrapper:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add the frontend model code for clarity?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corresponding frontend code has been added.

@svekars svekars requested a review from msaroufim July 27, 2023 14:10
@chunyuan-w
Copy link
Contributor Author

Hi @svekars, may I know if you could help with the approval for CI workflow?
image

@chunyuan-w
Copy link
Contributor Author

@desertfire FYI I drafted the Cpp Wrapper tutorial (mainly for the CPU part). You may check if any GPU related information needs to be added.

chunyuan-w and others added 14 commits August 15, 2023 10:44
@chunyuan-w @svekars
Update prototype_source/inductor_cpp_wrapper_tutorial.rst
da3c5a0 
Co-authored-by: Svetlana Karslioglu <[email protected]>
@chunyuan-w @svekars
Update prototype_source/inductor_cpp_wrapper_tutorial.rst
6d34267 
Co-authored-by: Svetlana Karslioglu <[email protected]>
@chunyuan-w @svekars
Update prototype_source/inductor_cpp_wrapper_tutorial.rst
a5ab18d 
Co-authored-by: Svetlana Karslioglu <[email protected]>
@chunyuan-w @svekars
Update prototype_source/inductor_cpp_wrapper_tutorial.rst
4eea963 
Co-authored-by: Svetlana Karslioglu <[email protected]>
@chunyuan-w @svekars
Update prototype_source/inductor_cpp_wrapper_tutorial.rst
201a5c1 
Co-authored-by: Svetlana Karslioglu <[email protected]>
@chunyuan-w @svekars
Update prototype_source/inductor_cpp_wrapper_tutorial.rst
528138c 
Co-authored-by: Svetlana Karslioglu <[email protected]>
@chunyuan-w @svekars
Update prototype_source/inductor_cpp_wrapper_tutorial.rst
2ae1b27 
Co-authored-by: Svetlana Karslioglu <[email protected]>
@chunyuan-w @svekars
Update prototype_source/inductor_cpp_wrapper_tutorial.rst
7d0ef78 
Co-authored-by: Svetlana Karslioglu <[email protected]>
@chunyuan-w @svekars
Update prototype_source/inductor_cpp_wrapper_tutorial.rst
926a112 
Co-authored-by: Svetlana Karslioglu <[email protected]>
@chunyuan-w @svekars
Update prototype_source/inductor_cpp_wrapper_tutorial.rst
0e016e8 
Co-authored-by: Svetlana Karslioglu <[email protected]>
@chunyuan-w @svekars
Update prototype_source/inductor_cpp_wrapper_tutorial.rst
a10b337 
Co-authored-by: Svetlana Karslioglu <[email protected]>
@chunyuan-w @svekars
Update prototype_source/inductor_cpp_wrapper_tutorial.rst
788766f 
Co-authored-by: Svetlana Karslioglu <[email protected]>
@chunyuan-w
add more details in Conclusion
e736959
@chunyuan-w
addempty line
8496aa3
@chunyuan-w
Copy link
Contributor Author

Thanks so much! Just a few editorial suggestions. As I understand, this is the 2.1 feature? We typically merge the tutorials that support a release on the day of the release. Please let me know if you have any questions

Thanks for the suggestions! I've addressed all of them.
Yes this is a 2.1 feature. Sure we can land it on the day of the release following your common practice.

svekars
svekars reviewed Aug 15, 2023
View reviewed changes
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chunyuan-w! Just a couple of very tiny corrections and we are good. =)

prototype_source/inductor_cpp_wrapper_tutorial.rst Outdated Show resolved Hide resolved
prototype_source/inductor_cpp_wrapper_tutorial.rst Outdated Show resolved Hide resolved
prototype_source/inductor_cpp_wrapper_tutorial.rst Outdated Show resolved Hide resolved
prototype_source/inductor_cpp_wrapper_tutorial.rst Outdated Show resolved Hide resolved
prototype_source/inductor_cpp_wrapper_tutorial.rst Outdated Show resolved Hide resolved
@chunyuan-w
Copy link
Contributor Author

Thanks @chunyuan-w! Just a couple of very tiny corrections and we are good. =)

Thanks for the review! I've addressed them as suggested.

@svekars svekars merged commit 420399d into pytorch:main Oct 2, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgong5 jgong5 jgong5 approved these changes

@svekars svekars svekars approved these changes

@msaroufim msaroufim msaroufim approved these changes

Assignees
No one assigned
Labels
2.1 cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chunyuan-w @msaroufim @svekars @jgong5 @facebook-github-bot